feat(ids): accept a Notion URL wherever an id belongs - #47
Draft
gauravmm wants to merge 1 commit into
Draft
Conversation
A page URL is what the Notion app puts on the clipboard, so callers paste
one. The API answered invalid_request_url with no hint about what to send.
notionId() normalizes a URL or a bare 32-hex id to a dashed uuid, across
41 id fields. Anything else passes through, so a bad id fails as before.
z.preprocess rather than .transform: a transform emits {} as its JSON
Schema and would drop the type and description from notion_describe.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YM3ZVWH22UzzTTbbkoJw9P
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A page URL is what the Notion app puts on the clipboard, so callers paste one. The API answered
invalid_request_urlwith no hint about what to send instead.notionId()normalizes a URL or a bare 32-hex id to a dashed uuid, across 41 id fields. Anything else passes through, so a bad id fails as before.z.preprocessrather than.transform: a transform emits{}as its JSON Schema and would drop the type and description fromnotion_describe.Adds tests that fail without the fix. Suite stays green.